Fix unaligned memory access when reading DRM events #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
force-pushed
the
simon/unaligned-access-fix
branch
from
55d96b1
to
c4c4bd0
Compare
|
Could you rebase this one as well please? :) |
Running with debug assertions enabled on armv7 (an stm32mp157) panics due to unaligned memory reads: thread 'main' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0xbec90b44', .../drm-0.9.0/src/control/mod.rs:906:34 Fix this by using the corresponding functions from core to safely copy the data (in C we'd do a memcpy).
tronical
force-pushed
the
simon/unaligned-access-fix
branch
from
c4c4bd0
to
ec6fdee
Compare
|
Done. Sorry, took a while :). The |
Just remove them and see if CI fails. If it does we need to add them again. (I think the error comes from different type-aliases on different platforms, so this is difficult to test outside of CI.) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with debug assertions enabled on armv7 (an stm32mp157) panics due to unaligned memory reads:
thread 'main' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0xbec90b44', .../drm-0.9.0/src/control/mod.rs:906:34
Fix this by using the corresponding functions from core to safely copy the data (in C we'd do a memcpy).